Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: plugin-html支持把div转换成static-view或pure-view #14602

Merged
merged 18 commits into from
Nov 7, 2023
Merged

feat: plugin-html支持把div转换成static-view或pure-view #14602

merged 18 commits into from
Nov 7, 2023

Conversation

leiyu0932
Copy link
Contributor

@leiyu0932 leiyu0932 commented Sep 25, 2023 •
edited by Chen-jj
Loading

这个 PR 做了什么? (简要描述所做更改)

html-plugin 支持 把 div 转换成 static-view 或 pure-view， 当有事件绑定时还是转换成view， 当没有事件有自定义属性时转换成static-view， 当 没有事件也没有自定义属性时，转换成 pure-view

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix catchMove 使用在 HTML 标签上不生效 #14657
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）
  • 鸿蒙（harmony）

@taro-bot2
Copy link

taro-bot2 bot commented Sep 25, 2023

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献！🌷🌷🌷

一般 PR 会在一到两周内进行 review，成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间，所以请遵循以下规范，协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景（非常重要，例如解决了什么问题，该问题如何复现等）
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通，请加入 Taro 开发者微信群：

@taro-bot2 taro-bot2 bot mentioned this pull request Sep 30, 2023
Closed
Chen-jj
Chen-jj requested changes Oct 11, 2023
View reviewed changes
packages/taro-runtime/src/hydrate.ts Show resolved Hide resolved
packages/shared/src/runtime-hooks.ts Show resolved Hide resolved
packages/taro-plugin-html/src/runtime.ts Show resolved Hide resolved
@taro-bot2 taro-bot2 bot mentioned this pull request Oct 14, 2023
Closed
leiyu0932
leiyu0932 commented Oct 17, 2023
View reviewed changes
packages/taro-plugin-html/src/index.ts Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这块 span 改到了 行内元素数组里， 与dom-external/inner-html/tags 里的 isBlockElements 方法 保持一致， 要不当使用span元素的时候会有问题， 如果 有特殊原因 不能调整， 我这边 再重新 定义 一个 isBlockElements 方法， 包含span的

@taro-bot2 taro-bot2 bot mentioned this pull request Oct 21, 2023
Closed
@taro-bot2 taro-bot2 bot mentioned this pull request Oct 28, 2023
Closed
Chen-jj
Chen-jj requested changes Oct 31, 2023
View reviewed changes
packages/shared/src/runtime-hooks.ts Show resolved Hide resolved
packages/taro-plugin-html/src/utils.ts Outdated Show resolved Hide resolved
packages/taro-plugin-html/src/utils.ts Outdated Show resolved Hide resolved
packages/taro-runtime/src/hydrate.ts Outdated Show resolved Hide resolved
packages/taro-runtime/src/dom/element.ts Outdated Show resolved Hide resolved
packages/taro-runtime/src/dom/element.ts Outdated Show resolved Hide resolved
packages/taro-runtime/src/dom/element.ts Outdated Show resolved Hide resolved
@taro-bot2 taro-bot2 bot mentioned this pull request Nov 4, 2023
Closed
@Chen-jj Chen-jj merged commit 2f73a26 into NervJS:next Nov 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chen-jj Chen-jj Chen-jj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

catchMove 使用在 HTML 标签上不生效
2 participants
@leiyu0932 @Chen-jj