-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: plugin-html支持把div转换成static-view或pure-view #14602
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chen-jj
requested changes
Oct 11, 2023
leiyu0932
commented
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这块 span 改到了 行内元素数组里, 与dom-external/inner-html/tags 里的 isBlockElements 方法 保持一致, 要不当使用span元素的时候会有问题, 如果 有特殊原因 不能调整, 我这边 再重新 定义 一个 isBlockElements 方法, 包含span的
leiyu0932
commented
Oct 17, 2023
Chen-jj
requested changes
Oct 31, 2023
Chen-jj
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
html-plugin 支持 把 div 转换成 static-view 或 pure-view, 当有事件绑定时还是转换成view, 当没有事件有自定义属性时转换成static-view, 当 没有事件也没有自定义属性时,转换成 pure-view
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: