Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修改判断,考虑初始绑定的事件为空的情况 #15540

Merged
merged 4 commits into from
May 10, 2024

Conversation

shushu2013
Copy link
Contributor

这个 PR 做了什么? (简要描述所做更改)

修改判断,考虑初始绑定的事件为空(没有旧的事件绑定的情况)

这个 PR 是什么类型? (至少选择一个)

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

Copy link

taro-bot2 bot commented Apr 19, 2024

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献!🌷🌷🌷

一般 PR 会在一到两周内进行 review,成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间,所以请遵循以下规范,协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景(非常重要,例如解决了什么问题,该问题如何复现等)
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通,请加入 Taro 开发者微信群:

1 similar comment
Copy link

taro-bot2 bot commented Apr 19, 2024

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献!🌷🌷🌷

一般 PR 会在一到两周内进行 review,成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间,所以请遵循以下规范,协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景(非常重要,例如解决了什么问题,该问题如何复现等)
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通,请加入 Taro 开发者微信群:

Copy link
Contributor

@koppthe koppthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢 PR~ 这里的判断逻辑不用修改,应该是修改以下代码吧

unstable_batchedUpdates(() => newEventHandler.call(this, e))

改为

unstable_batchedUpdates(() => newEventHandler && newEventHandler.call(this, e))

@shushu2013
Copy link
Contributor Author

感谢 PR~ 这里的判断逻辑不用修改,应该是修改以下代码吧

unstable_batchedUpdates(() => newEventHandler.call(this, e))

改为

unstable_batchedUpdates(() => newEventHandler && newEventHandler.call(this, e))

newEventHandler 和 oldEventHandler 都不存在,应该不用运行到这一步再判断,直接第一步就判断处理,就可以了吧

This was referenced May 4, 2024
@koppthe koppthe added this to the 3.6.29 milestone May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.62%. Comparing base (f45c37e) to head (e3fb81a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15540      +/-   ##
==========================================
- Coverage   58.68%   58.62%   -0.06%     
==========================================
  Files         500      500              
  Lines       21997    21943      -54     
  Branches     5541     5536       -5     
==========================================
- Hits        12909    12865      -44     
+ Misses       8139     8040      -99     
- Partials      949     1038      +89     
Flag Coverage Δ
taro-cli 75.00% <ø> (+23.39%) ⬆️
taro-runner 54.00% <ø> (ø)
taro-runtime 79.39% <ø> (ø)
taro-web 51.60% <ø> (+6.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 37 files with indirect coverage changes

@koppthe koppthe self-assigned this May 6, 2024
@koppthe koppthe merged commit 396253e into NervJS:main May 10, 2024
22 checks passed
@onegaop
Copy link

onegaop commented Sep 5, 2024

newEventHandler

要判断,taro 3.6.35 报错了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-components Area - H5 组件库相关 T-h5 Target - 编译到 H5
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Taro 3.6.26 View 初始绑定 onClick 为 undefined,点击报错
4 participants