trident-csi Info log is too verbose

[superbrothers]

Info log level of trident-csi is 9 which is Trace level verbosity.

apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  name: trident-csi
  labels:
    app: {LABEL}
spec:
    (...)
      - name: csi-provisioner
        image: quay.io/k8scsi/csi-provisioner:v1.2.1
        args:
        - "--v=9"
        - "--timeout=600s"
        - "--csi-address=$(ADDRESS)"
        env:
    (...)

• https://github.com/NetApp/trident/blob/stable/v19.07/cli/k8s_client/yaml_factory.go#L355-L403

It is too verbose, and has a negative inpact on log aggregation system. Furthermore, The logs include ServiceAccount token. It is not appropriate for security reasons.

I0821 13:07:07.616211       1 round_trippers.go:419] curl -k -v -XGET  -H "Authorization: Bearer eyJhbGciOiJFUzI1NiIsImtpZCI6IiJ9.eyJpc3MiOiJrdWJlcm5ldGVzL3NlcnZpY2VhY2NvdW50Iiwia3ViZXJuZXRlcy5pby9zZXJ2aWNlYWNjb3VudC9uYW1lc3BhY2UiOiJ0cmlkZW50Iiwia3ViZXJuZXRlcy5pby9zZXJ2aWNlYWNjb3VudC9zZWNyZXQubmFtZSI6InRyaWRlbnQtY3NpLXRva2VuLTc5dmJkIiwia3ViZXJuZXRlcy5pby9zZXJ2aWNlYWNjb3VudC9zZXJ2aWNlLWFjY291bnQubmFtZSI6InRyaWRlbnQtY3NpIiwia3ViZXJuZXRlcy5pby9zZXJ2aWNlYWNjb3VudC9zZXJ2aWNlLWFjY291bnQudWlkIjoiZDAxYjBhMTYtYzNlNy0xMWU5LTg1MGUtZmExNjNlZGQ0ODFlIiwic3ViIjoic3lzdGVtOnNlcnZpY2VhY2NvdW50OnRyaWRlbnQ6dHJpZGVudC1jc2kifQ.1PEy-1kpdwDME-mJyA_X0Wuw8N2y0jwd71mxamElRnhfjUFWPXwLRQ12imvO1MkQ1duH9XkmkAsj94l9fyWDeg" -H "User-Agent: csi-attacher/v0.0.0 (linux/amd64) kubernetes/$Format" -H "Accept: application/json, */*" 'https://10.27.0.1:443/apis/storage.k8s.io/v1beta1/csinodes?resourceVersion=43960009&timeout=8m19s&timeoutSeconds=499&watch=true'
I0821 13:07:07.616477       1 round_trippers.go:438] GET https://10.27.0.1:443/api/v1/nodes?resourceVersion=43960385&timeout=9m42s&timeoutSeconds=582&watch=true 200 OK in 1 milliseconds
I0821 13:07:07.616532       1 round_trippers.go:444] Response Headers:
I0821 13:07:07.616555       1 round_trippers.go:447]     Content-Type: application/json
I0821 13:07:07.616579       1 round_trippers.go:447]     Date: Wed, 21 Aug 2019 13:07:07 GMT
I0821 13:07:07.616638       1 round_trippers.go:438] GET https://10.27.0.1:443/apis/storage.k8s.io/v1beta1/volumeattachments?resourceVersion=43915399&timeout=8m1s&timeoutSeconds=481&watch=true 200 OK in 5 milliseconds
I0821 13:07:07.616717       1 round_trippers.go:444] Response Headers:
I0821 13:07:07.616768       1 round_trippers.go:447]     Content-Type: application/json
I0821 13:07:07.616805       1 round_trippers.go:447]     Date: Wed, 21 Aug 2019 13:07:07 GMT

[korenaren]

Thanks @superbrothers - what level would make sense?

[clintonk]

https://kubernetes.io/docs/reference/kubectl/cheatsheet/#kubectl-output-verbosity-and-debugging

--v=2 --> Useful steady state information about the service and important log messages that may correlate to significant changes in the system. This is the recommended default log level for most systems.

It seems reasonable to use 2 for the default case, and 9 for debug installs.