Add equality comparison for ArchaiusType #700
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds equality methods for the
ArchaiusType
class to ensurekeyAndType
references are reused correctly within theDefaultPropertyFactory
.The
computeIfAbsent
check for existing property references uses thetype
equality withinkeyAndType
to see if a reference to a property already exists, otherwise it adds it to the property ref map.This can cause an explosion of allocations where the same property key and type are supplied, but as the type itself is constructed on every fetch (
new ArchaiusType
), the default java object equals methods always return false, so a new reference is added to the property factory.