Add a Decoder that accepts custom TypeConverters #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilink
force-pushed
the
custom-converters
branch
from
906a0a4
to
8cc14ec
Compare
| } | ||
| return Optional.empty(); | ||
| }; | ||
| DefaultDecoder customDecoder = DefaultDecoder.newCustomDecoder(Collections.singletonList(customTypeConverterFactory)); |
There was a problem hiding this comment.
Naming here is ... unfortunate. Do you feel like it would be worthwhile to rename the classes a bit? Maybe move the existing code to a CustomizableDecoder that has your static factory and making DefaultDecoder be a sublcass of it that calls the constructor with an empty factory list?
There was a problem hiding this comment.
I would probably just create a base class that they both share in that case, AbstractDecoder / AbstractRegistryDecoder, or something like that.
kilink
force-pushed
the
custom-converters
branch
from
8cc14ec
to
6f1f93e
Compare
Add a new Decoder implementation, CustomDecoder, which allows users to specify custom type converters via its static factory method, create. To avoid duplicate code, introduce a new package private base class, AbstractRegistryDecoder, which the existing DefaultDecoder and CustomDecoder both extend. CustomDecoder will add the default factories used by DefaultDecoder as well, placing them after the custom ones so that they may be overridden and are only used as fallbacks.
kilink
force-pushed
the
custom-converters
branch
from
6f1f93e
to
b7ebce5
Compare
kilink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new Decoder,
CustomDecoder, which allows users to easily specify customTypeConverterimplementations.CustomDecoderexposes a single static factory method,create, which accepts a Collection ofTypeConverter.Factoryinstances.As part of adding this feature, refactor
DefaultDecoderin a re-usable base class,AbstractRegistryDecoder, whichCustomDecoderalso extends from.