Fix instrumentation propagation of PrefixedViewConfigs #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrefixedViewConfigs, on updates from configs that it depends on, did not propagate updates to configs that depend on it, meaning any fast property updates for example would be lost.
Example: For the situation of a CompositeConfig over a PrefixedViewConfig over an instrumented config, any accesses on the overarching CompositeConfig would not be properly re-prefixed with the PrefixedViewConfig when propagating instrumentation data to the instrumented config.
Consider CompositeConfig.getRawProperty("prop") for PrefixedViewConfig with prefix "prefix"
Previous behavior: Instrumented config tries to record usage for "prop", but that's not actually the property being accessed.
Fixed behavior: PrefixedViewConfig when passed through prepends "prefix." resulting in the expected "prefix.prop" being reported as accessed.