Only load properties with the log4j prefix #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgallardo-netflix
requested changes
Dec 7, 2023
rgallardo-netflix
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the fast property instrumentation effort, we are modifying locations in code that iterate over all properties in order to reduce the amount of noise.
Blitz4j only reads log4j-prefixed properties for overrides, so we change the code here to only read those, instead of first reading then filtering.
This copies up the method from Apache commons configuration https://github.com/apache/commons-configuration/blob/CONFIGURATION_1_10/src/main/java/org/apache/commons/configuration/ConfigurationConverter.java#L105