This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
JOIN task is made async #3284
Merged
JOIN task is made async #3284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apanicker-nflx
force-pushed
the
async_join
branch
from
58e9cc8 to
7657adc
Compare
jxu-nflx
approved these changes
Oct 12, 2022
apanicker-nflx
force-pushed
the
async_join
branch
4 times, most recently
from
21f36dc to
0fa8948
Compare
apanicker-nflx
force-pushed
the
async_join
branch
from
0fa8948 to
17efd8a
Compare
franrull
reviewed
Jun 9, 2023
| if (isLazyEvaluateWorkflow(workflowInstance.getWorkflowDefinition(), task)) { | ||
| expediteLazyWorkflowEvaluation(workflowId); | ||
| } else { | ||
| if (!isLazyEvaluateWorkflow(workflowInstance.getWorkflowDefinition(), task)) { |
There was a problem hiding this comment.
@apanicker-nflx What's the intent of this change? It seems like an oversight cause if the condition is false (in other words, the workflow isLazyEvalute), nothing happens anymore.
|
Hi~ Make JOIN task async causing a problem.Can anyone fix it or just make JOIN sync ?#3528 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
The JOIN task is made async and will be evaluated by the async system task executor and the system task workers off the JOIN task queue. This improves the efficiency of workflow evaluations because the workflow will now be evaluated only after the JOIN task reaches a terminal state rather than for every forked task update leading to empty evaluations.