Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

feature: Add option to add payloadBytes into getLocation method #3383

Conversation

SimonMisencik
Copy link
Contributor

@SimonMisencik SimonMisencik commented Dec 8, 2022

Signed-off-by: Simon Misencik simon.misencik@gmail.com

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
  • WHOSUSING.md
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

Discussion: #3384

This PR adds an option to add payloadBytes variable into the getLocation method. These payloadBytes are then used in externalStorage to calculate the digest. This digest is then used to determine whether the same data is already stored in the database.

Alternatives considered

Describe alternative implementation you have considered

@SimonMisencik SimonMisencik marked this pull request as draft December 8, 2022 12:45
@SimonMisencik SimonMisencik marked this pull request as draft December 8, 2022 12:45
Signed-off-by: Simon Misencik <simon.misencik@gmail.com>
@SimonMisencik SimonMisencik force-pushed the remove_duplicate_data_in_external_storage branch from fcd7db4 to cb18036 Compare December 8, 2022 13:08
@SimonMisencik SimonMisencik marked this pull request as ready for review December 8, 2022 13:42
@github-actions
Copy link
Contributor

This PR is stale, because it has been open for 45 days with no activity. Remove the stale label or comment, or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 23, 2023
Copy link
Contributor

@marosmars marosmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v1r3n could you please take a look ?

We would like to extend the API to allow external storage service to calculate object ID based on its content

@apanicker-nflx apanicker-nflx added the type: feature New feature label Jan 23, 2023
@apanicker-nflx apanicker-nflx merged commit 06c25e7 into Netflix:main Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants