Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Update to Java 17 #3733

Merged
merged 16 commits into from
Sep 16, 2023
Merged

Update to Java 17 #3733

merged 16 commits into from
Sep 16, 2023

Conversation

alexmay48
Copy link
Contributor

Pull Request type

  • [ X ] Feature
  • [ X ] Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

This updates the repo to use Java 17 instead of Java 11. To accomplish this, we do need to pull in the Nashorn Scripting Engine library explicitly to use it. We could consider allowing the users to configure to use their own implementation of a scripting engine, but that can be done in a new feature MR.

@alexmay48
Copy link
Contributor Author

@v1r3n , this should pass the build check if the Github Actions was setup to use Java 17. Thanks.

@egandro
Copy link

egandro commented Aug 27, 2023

Any upgrade on this?

@egandro
Copy link

egandro commented Sep 8, 2023

Any updates on this?

@egandro
Copy link

egandro commented Sep 8, 2023

@alexmay48 I consider creating a fork since so many many PRs are stalled :(

Are you willing to join forces?

@alexmay48
Copy link
Contributor Author

@egandro
I am working on this repo because my company relies on it, and so we make changes as needed. I don't think we have a big need to push some of these features through or to rely on a forked repo. You'll have to ask the maintainers about pushing PRs through. I made this Java 17 change because it would be a nice to have, but it's not necessary for us at the moment.

@v1r3n
Copy link
Contributor

v1r3n commented Sep 8, 2023

Hi @alexmay48 we are reviewing, and this should be part of the next release. JDK 17 is a major update and we need to ensure it preserves backward compatibility.

@v1r3n
Copy link
Contributor

v1r3n commented Sep 9, 2023

@alexmay48 do you want to update the GitHub workflows as well to use JDK17?

@v1r3n v1r3n merged commit 013e820 into Netflix:main Sep 16, 2023
1 of 2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants