Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

ISICO-15108: javascript validation done on updating w/d #3805

Merged
merged 5 commits into from
Nov 25, 2023

Conversation

sarmuru2
Copy link
Contributor

@sarmuru2 sarmuru2 commented Oct 10, 2023

While adding a workflow definition, its required to validate the javascript snippet added in the decision/switch task. This will help to avoid the errors in switch task during workflow execution.

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
  • WHOSUSING.md
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

Describe the new behavior from this PR, and why it's needed
Issue #

Alternatives considered

Describe alternative implementation you have considered

@manan164
Copy link
Contributor

Hi @sarmuru2 , Thanks for the contribution. Can you please add a few tests cases for this?

@sarmuru2
Copy link
Contributor Author

HI @manan164 , I have added the test cases. Please review it now.

@dcore94
Copy link
Contributor

dcore94 commented Oct 26, 2023

Should definitely be applied also to INLINE tasks....

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants