Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect does not adjust cache size. #507

Closed
ThePrimeagen opened this issue Aug 31, 2015 · 0 comments
Closed

Collect does not adjust cache size. #507

ThePrimeagen opened this issue Aug 31, 2015 · 0 comments
Labels

Comments

@ThePrimeagen
Copy link
Contributor

The two places in which we call collect (in the upcoming getRequestCycle.js and IdempotentResponse.js) we do not pass in a version flag. That version flag is required to update the graph which would update the size. This is extremely problematic because every request to a dataSource will cause the LRU to be further cleaned up.

A good unit test would be to test lru/collect to ensure size changes. Test a get that will exceed the cache and after the observable completes (some sort of setTimeout) the cache size must be reduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant