Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty keyset bug #979

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Empty keyset bug #979

merged 2 commits into from
Jul 29, 2020

Conversation

jcranendonk
Copy link
Contributor

When calling Model.get() with overlapping path sets where a subsequent path set contains an empty key set, some values in the result are lost. This has been fixed by not overwriting an existing result node.

@jcranendonk jcranendonk merged commit a7b6a89 into master Jul 29, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 92.619% when pulling 7d0e368 on emptyKeysetBug into e144f12 on master.

@jcranendonk jcranendonk deleted the emptyKeysetBug branch July 29, 2020 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants