Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not reporting missing VideoLineMap element #296

Closed
fschleich opened this issue Nov 10, 2021 · 2 comments · Fixed by #391
Closed

Not reporting missing VideoLineMap element #296

fschleich opened this issue Nov 10, 2021 · 2 comments · Fixed by #391
Assignees
@cfadamp
Milestone
v4.x

Comments

@fschleich
Copy link
Contributor

Photon currently does not report an error for the attached CPL (or the complete package), even though the VideoLineMap element is missing from the CDCI Descriptor.

Even though the element "shall be ignored" according to ST 2067-20:2016, VideoLineMap is a Best Effort element per ST 377-1:2011 Section F.4.1 Generic Picture Essence Descriptor. The element shall therefore be present in the encoded file and an error should be raised.

CPL.xml.txt
@cfadamp
Copy link
Contributor

cfadamp commented Oct 15, 2024

please assign to me

@palemieux palemieux added this to the v4.x milestone Oct 15, 2024
@danielhdz13-netflix
Copy link
Contributor

From a cursory glance, a property annotated with @MXFProperty can be added to the CDCI Descriptor class. Other relevant classes might be MXFPropertyPopulator, and StructuralMetadata.

cfadamp added a commit to cfadamp/photon that referenced this issue Oct 27, 2024
@cfadamp
Update CompositionImageEssenceDescriptorModel.java
5a9a88b 
Fix for Netflix#296 . Missing VideoLineMap element shall be reported for all applications.
@cfadamp cfadamp mentioned this issue Oct 27, 2024
Merged
fschleich pushed a commit that referenced this issue Nov 19, 2024
@cfadamp
Update CompositionImageEssenceDescriptorModel.java (#391)
096bff9 
Fix for #296 . Missing VideoLineMap element shall be reported for all applications.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cfadamp cfadamp

Labels
None yet
Projects
None yet
Milestone
v4.x
Development

Successfully merging a pull request may close this issue.

[Bugfix] Missing VideoLineMap element shall be reported for all applications cfadamp/photon
4 participants
@palemieux @cfadamp @fschleich @danielhdz13-netflix