add unix spectatord output location #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new spectatord output location, `unix`, which selects the default Unix Domain Socket used by spectatord. This saves the user from having to lookup this value. Add Registry tests to validate that the with-id methods add any extra common tags that are specified in the Config. This is true as long as the `NewId` method on the `Registry` is used to create `Id`s. In the Config, it is not necessary to check the result from `tagsFromEnvVars`, because only non-empty values are added to the map.
sgg
added a commit
that referenced
this pull request
Aug 20, 2024
PR #105 allowed the use of the `unix` as a shorthand for spectatord's default unix socket path. This diff updates the config validation logic so that folks can pass that value in.
copperlight
pushed a commit
that referenced
this pull request
Aug 20, 2024
PR #105 allowed the use of the `unix` as a shorthand for spectatord's default unix socket path. This diff updates the config validation logic so that folks can pass that value in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new spectatord output location,
unix, which selects the default Unix Domain Socket used by spectatord. This saves the user from having to lookup this value.Add Registry tests to validate that the with-id methods add any extra common tags that are specified in the Config. This is true as long as the
NewIdmethod on theRegistryis used to createIds.In the Config, it is not necessary to check the result from
tagsFromEnvVars, because only non-empty values are added to the map.