Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude empty outputs in requests #7720

Merged
merged 679 commits into from
Dec 15, 2024
Merged

Exclude empty outputs in requests #7720

merged 679 commits into from
Dec 15, 2024

Conversation

rjnrohit
Copy link
Contributor

@rjnrohit rjnrohit commented Nov 5, 2024

Changes

Implements changes from these spec PRs:

Types of changes

  1. Exclude the empty requests from hash calculation
  2. Add type prefix byte to the ExecutionRequests for the engineAPIs

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

@rjnrohit rjnrohit changed the title exclude empty outputs in requests commitment Exclude empty outputs in requests commitment Nov 5, 2024
@rjnrohit rjnrohit requested a review from LukaszRozmej November 5, 2024 16:19
@rjnrohit rjnrohit changed the title Exclude empty outputs in requests commitment Exclude empty outputs in requests Nov 5, 2024
Base automatically changed from flat_encoding_requests to master November 6, 2024 11:44
Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off on merging this for now as it may break Mekong. The changes look good overall.

@MarekM25 MarekM25 merged commit f738577 into master Dec 15, 2024
79 checks passed
@MarekM25 MarekM25 deleted the empty_requests branch December 15, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants