fix: scarb checkout contracts for newer versions. Fix commit for current scarb commit #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@taco-paco is attempting to deploy a commit to the Starknet Remix Plugin Team on Vercel. A member of the Team first needs to authorize it. |
satyambnsal
reviewed
Jul 18, 2024
| @@ -749,6 +749,7 @@ const Compilation: React.FC<CompilationProps> = ({ setAccordian }) => { | |||
| // const get all values of allFiles object | |||
| const allFilesValues = Object.values(allFiles) | |||
|
|
|||
| console.log('allFiles', allFiles) | |||
There was a problem hiding this comment.
Seems unnecessarily, perhaps just remove it.
There was a problem hiding this comment.
Oops, thought removed it. Thanks, good catch
| } | ||
| } | ||
| const checkVal = Object.values(allFilesValues[i])[0] | ||
| console.log('checkVal', checkVal, allFilesValues[i], checkVal === '', checkVal === null, checkVal === undefined, isEmpty(checkVal)) |
There was a problem hiding this comment.
Seems unnecessarily, perhaps just remove it.
| ): Promise<Array<({ fileName: string, content: string, path: string } | null)>> { | ||
| const apiUrl = `https://api.github.com/repos/${repository}/contents/${path}` | ||
| const apiUrl = (function () { |
There was a problem hiding this comment.
Curious why this needs to be IIFE ?
can't we just do this
const apiUrl = `https://api.github.com/repos/${repository}/contents/${path}${ref === undefined ? '' : `?ref=${ref}`}`
There was a problem hiding this comment.
Just a preference. Can be anything. But I would leave it like this, other option looks a bit clumsy for me.
|
Overall looks good. Few minor comments. |
|
can you pull & merge develop into this branch please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ent scarb release