Update cairo writer to have valid erc20 on cairo1 #924

AlejandroLabourdette · 2023-02-14T14:02:26Z

This PR is deprecated because create some unexpected conflicts while rebasing to cairo-1.0. The PR that substitute this one is #969

…into writer-cairo1

This reverts commit 5827453.

This reverts commit 5b1391e.

* Modify returnWriter * Modify variableDeclarationStatementWriter * Remove unused imports --------- Co-authored-by: Piotr Piwoński <piwonskp>

src/cairoWriter/writers/cairoContractWriter.ts

src/cairoWriter/writers/variableDeclarationWriter.ts

rodrigo-pino · 2023-02-27T13:54:34Z

Please be sure that the PR is properly linted before merging

src/cairoWriter/writers/memberAccessWriter.ts

src/cairoWriter/utils.ts

src/cairoWriter/writers/cairoAssertWriter.ts

src/cairoWriter/writers/cairoContractWriter.ts

src/cairoWriter/writers/ifStatementWriter.ts

This reverts commit cc406a8.

src/cairoWriter/writers/cairoAssertWriter.ts

piwonskp · 2023-03-02T11:00:41Z

506 changes all of a sudden? Something went wrong with the latest commit

rjnrohit · 2023-03-02T13:21:27Z

506 changes all of a sudden? Something went wrong with the latest commit

Yes, It's including some old changes

AlejandroLabourdette · 2023-03-02T14:00:48Z

506 changes all of a sudden? Something went wrong with the latest commit

That last commit did some weird changes, I'm not sure what happen there

rjnrohit · 2023-03-03T11:29:21Z

I would suggest closing this PR and break it's into small small PRs handling one issue at a time.

AlejandroLabourdette and others added 4 commits February 14, 2023 07:40

update cairoAssertWriter

ba9c2a7

update import writer

cc406a8

Cleanup assertWriter

de4150d

change contract structure

7fe0102

AlejandroLabourdette marked this pull request as draft February 15, 2023 14:00

AlejandroLabourdette and others added 18 commits February 15, 2023 09:06

update header of func def

35a2d59

Merge branch 'writer-cairo1' of https://github.com/NethermindEth/warp …

4abb468

…into writer-cairo1

assert cairo writer should compare to 1 the expr

274ac8b

remove parenthesis to variables from assign

c7d1826

remove tempvar keyword from tempVarWriter

3a17704

update event writer

b9fdfc3

remove parenthesis from condition in if's

d7d26d0

update return writer

5827453

update expressionStatementWriter

25e47fd

update variableDeclaration writers

5b1391e

member access with ::

b989920

updateFunctionCallWriter

8b550f0

Revert "update return writer"

ce3839b

This reverts commit 5827453.

Revert "update variableDeclaration writers"

521b360

This reverts commit 5b1391e.

update variableDeclarationWriter

3143017

remove comment over structs in func call writer

49e7b47

remove Uint256 from literalWriter

58d36c9

Cairo 1.0 writers (#944)

1e81cb9

* Modify returnWriter * Modify variableDeclarationStatementWriter * Remove unused imports --------- Co-authored-by: Piotr Piwoński <piwonskp>

AlejandroLabourdette marked this pull request as ready for review February 23, 2023 14:08

rodrigo-pino reviewed Feb 24, 2023

View reviewed changes

AlejandroLabourdette added 2 commits February 27, 2023 02:47

change to const state variables with constant value

9a7c55b

update member access

b2ba584

AlejandroLabourdette added 2 commits February 27, 2023 11:56

change storage code function header

d14987a

move const, structs and util func from source unit to contract writer

22868ea

piwonskp reviewed Feb 27, 2023

View reviewed changes

src/cairoWriter/writers/memberAccessWriter.ts Show resolved Hide resolved

if nothing to return then return ()

139b533