Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

partial update to func generation for Cairo1 #958

Merged
merged 19 commits into from
Mar 6, 2023
Merged

partial update to func generation for Cairo1 #958

merged 19 commits into from
Mar 6, 2023

Conversation

rodrigo-pino
Copy link
Contributor

No description provided.

@rodrigo-pino rodrigo-pino changed the base branch from develop to cairo1 February 24, 2023 02:40
piwonskp
piwonskp reviewed Mar 1, 2023
View reviewed changes
src/utils/cairoParsing.ts Outdated Show resolved Hide resolved
@piwonskp piwonskp changed the base branch from cairo1 to cairo-1.0 March 1, 2023 15:49
@piwonskp piwonskp changed the base branch from cairo-1.0 to cairo1 March 1, 2023 15:49
@rodrigo-pino rodrigo-pino changed the base branch from cairo1 to cairo-1.0 March 1, 2023 17:22
piwonskp
piwonskp reviewed Mar 2, 2023
View reviewed changes
src/utils/cairoParsing.ts Outdated Show resolved Hide resolved
rjnrohit
rjnrohit approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@rjnrohit rjnrohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except some places endent lib has been used some places it's not

piwonskp
piwonskp suggested changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@piwonskp piwonskp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One syntax error. Apart from that minor comments

src/cairoWriter/writers/cairoContractWriter.ts Outdated Show resolved Hide resolved
src/cairoUtilFuncGen/storage/mappingIndexAccess.ts Outdated Show resolved Hide resolved
src/cairoWriter/writers/cairoContractWriter.ts Outdated Show resolved Hide resolved
src/cairoUtilFuncGen/storage/mappingIndexAccess.ts Outdated Show resolved Hide resolved
src/cairoUtilFuncGen/storage/mappingIndexAccess.ts Outdated Show resolved Hide resolved
src/cairoUtilFuncGen/storage/mappingIndexAccess.ts Outdated Show resolved Hide resolved
@piwonskp piwonskp merged commit 26c3708 into cairo-1.0 Mar 6, 2023
@piwonskp piwonskp deleted the cairo1-storage-mappings branch March 6, 2023 18:51
This was referenced Mar 22, 2023
Closed
Closed
Closed
@JorikSchellekens JorikSchellekens mentioned this pull request May 15, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@piwonskp piwonskp piwonskp approved these changes

@rjnrohit rjnrohit rjnrohit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodrigo-pino @piwonskp @rjnrohit