Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

uintN->uN #967

Merged
merged 19 commits into from
Apr 13, 2023
Merged

uintN->uN #967

merged 19 commits into from
Apr 13, 2023

Conversation

rjnrohit
Copy link
Contributor

@rjnrohit rjnrohit commented Mar 3, 2023

closes #964

@rjnrohit rjnrohit changed the base branch from develop to cairo-1.0 March 3, 2023 05:08
piwonskp
piwonskp reviewed Mar 6, 2023
View reviewed changes
src/utils/utils.ts Outdated Show resolved Hide resolved
piwonskp
piwonskp reviewed Mar 6, 2023
View reviewed changes
src/utils/utils.ts Outdated Show resolved Hide resolved
piwonskp
piwonskp previously approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@piwonskp piwonskp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, some minor style changes

@rjnrohit rjnrohit closed this Mar 27, 2023
@rjnrohit rjnrohit deleted the uintn- branch March 27, 2023 08:13
@rjnrohit rjnrohit restored the uintn- branch March 27, 2023 08:13
@rjnrohit rjnrohit reopened this Mar 27, 2023
cicr99
cicr99 previously approved these changes Mar 27, 2023
View reviewed changes
@rjnrohit rjnrohit dismissed stale reviews from AlejandroLabourdette, cicr99, and piwonskp April 5, 2023 13:55

can you please again review this pr

@piwonskp piwonskp mentioned this pull request Apr 6, 2023
Merged
@rjnrohit rjnrohit requested a review from piwonskp April 7, 2023 06:14
@rjnrohit rjnrohit requested a review from cicr99 April 7, 2023 10:28
rodrigo-pino
rodrigo-pino reviewed Apr 11, 2023
View reviewed changes
src/utils/utils.ts Show resolved Hide resolved
warplib/memory.cairo Show resolved Hide resolved
@piwonskp
Copy link
Contributor

Conflicts

@rjnrohit
Copy link
Contributor Author

Conflicts

resolved

@rjnrohit rjnrohit enabled auto-merge (squash) April 13, 2023 12:28
@rjnrohit rjnrohit merged commit 22a693f into cairo-1.0 Apr 13, 2023
@rjnrohit rjnrohit deleted the uintn- branch April 13, 2023 12:28
@JorikSchellekens JorikSchellekens mentioned this pull request May 15, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@piwonskp piwonskp piwonskp approved these changes

@rodrigo-pino rodrigo-pino rodrigo-pino approved these changes

@AlejandroLabourdette AlejandroLabourdette Awaiting requested review from AlejandroLabourdette

@cicr99 cicr99 Awaiting requested review from cicr99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uint/intX -> uX : cairo1
5 participants
@rjnrohit @piwonskp @cicr99 @rodrigo-pino @AlejandroLabourdette