Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

Imports path structure #968

Merged
merged 19 commits into from
Mar 8, 2023
Merged

Imports path structure #968

merged 19 commits into from
Mar 8, 2023

Conversation

cicr99
Copy link
Contributor

@cicr99 cicr99 commented Mar 3, 2023

Changes addressed in this PR:

  • Change the imports writer to be compatible with Cairo1
  • The path to the imports in the CairoImportFunctionDefinition node changed to be an array of strings instead of a raw string
  • There is a new file src/utils/importFuncs that contains the definitions for all the import paths. This way, if an import needs to be changed, it is only necessary to change it here and not in the entire code.

Issues:

  • Warplib generated functions imports were not fixed, even though they are not compatible with cairo1, because warplib functions need to be modified as well, which is a different task.
  • All of the parsing to get the implicits of warplib functions was also not changed, as implicits are probably being removed

src/utils/importFuncs.ts Outdated Show resolved Hide resolved
src/warplib/utils.ts Outdated Show resolved Hide resolved
src/warplib/utils.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@piwonskp piwonskp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@rodrigo-pino rodrigo-pino merged commit d9fb605 into cairo-1.0 Mar 8, 2023
@rodrigo-pino rodrigo-pino deleted the imports_path branch March 8, 2023 00:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants