This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
Temporarily fix cairo-lang dependency version issues after major upgrades #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigo-pino
approved these changes
Mar 19, 2023
DimitrK
approved these changes
Mar 19, 2023
AlejandroLabourdette
approved these changes
Mar 20, 2023
rjnrohit
approved these changes
Mar 20, 2023
piwonskp
pushed a commit
that referenced
this pull request
Apr 4, 2023
* Fix cairo-lang dependencies issues after major upgrades (#995) * fix: typos (#991) * Bump @sideway/formula from 3.0.0 to 3.0.1 in /docs (#990) Bumps [@sideway/formula](https://github.com/sideway/formula) from 3.0.0 to 3.0.1. - [Release notes](https://github.com/sideway/formula/releases) - [Commits](hapijs/formula@v3.0.0...v3.0.1) --- updated-dependencies: - dependency-name: "@sideway/formula" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Franco Barpp Gomes <franco.b.gomes@gmail.com> Co-authored-by: julio4 <30329843+julio4@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was merging changes on my other PR, I noticed some issues when
starknetwas being executed on the workflow tests, and they didn't seem to have been caused by my changes.Turns out that the errors were related to breaking changes from two
cairo-langdependencies that were upgraded to the next major version literally like 3 days ago, more specificallyweb3andtypeguard. Sincecairo-langdidn't have a specific major version matching, it accepted the new package versions while not yet supporting them, and then these errors happened. There's already an open issue for this: starkware-libs/cairo-lang#151.In the latest
cairo-langpre-release,typeguardis already set to<3.0.0, butweb3isn't yet. When both of these are fixed and there's a new release, it would be good to upgrade it here. For the moment, I added explicit installs forweb3(==5.*) andtypeguard(==2.*), which seem to have done the trick.