Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polling status of execution #209

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

taco-paco
Copy link
Contributor

No description provided.

@taco-paco taco-paco requested a review from varex83 October 3, 2024 08:23
Copy link
Contributor

@varex83 varex83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -12,5 +12,7 @@ serde_json.workspace = true
thiserror.workspace = true
uuid.workspace = true

http = "1.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we setup it on the workspace level?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know workspace shall not contain all project dependencies, only most reused one. That will help version management in case any issue will be encountered.

@taco-paco taco-paco force-pushed the feat/horizontal/verify branch 2 times, most recently from 5550912 to 3bf7319 Compare October 18, 2024 12:47
@taco-paco taco-paco changed the base branch from feat/horizontal/verify to feat/horizontal/main October 18, 2024 12:59
@taco-paco taco-paco merged commit 56906e3 into feat/horizontal/main Oct 18, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants