fix(utils): use the reducer to build objects from entries (#79)

closes #78
NeuraLegion · Aug 28, 2020 · 7d89a67 · 7d89a67
1 parent f187ca8
commit 7d89a67
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 16 deletions.
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -21,7 +21,7 @@ jobs:
       - run: echo :set-env name=VERSION::${GITHUB_REF/refs\/tags\//}
       - run: npm ci -q
       - run: npm run build
-      - run: npm version --no-git-tag-version "$VERSION"
+      - run: npm version --no-git-tag-version $VERSION
       - run: npm run pack:win
 
       - uses: actions/upload-artifact@v2

diff --git a/.releaserc b/.releaserc
@@ -36,18 +36,7 @@
         "releasedLabels": false,
         "failTitle": false,
         "failComment": false,
-        "successComment": false,
-        "assets": [
-          {
-            "path": "bin/win64/nexploit-cli.exe",
-            "label": "nexploit-cli-windows-x64.exe"
-          },
-          { "path": "bin/mac/nexploit-cli", "label": "nexploit-cli-mac-x64" },
-          {
-            "path": "bin/linux/nexploit-cli",
-            "label": "nexploit-cli-linux-x64"
-          }
-        ]
+        "successComment": false
       }
     ]
   ],

diff --git a/src/Utils/Helpers.ts b/src/Utils/Helpers.ts
@@ -39,9 +39,11 @@ export class Helpers {
   public static parseHeaders(headers: string[] = []): Record<string, string> {
     ok(Array.isArray(headers), 'First argument must be an instance of Array.');
 
-    return Object.fromEntries(
-      headers.map((value: string) => this.parseHeader(value))
-    );
+    return headers.reduce((acc: Record<string, string>, value: string) => {
+      const [key, header]: [string, string] = this.parseHeader(value);
+
+      return { ...acc, [key]: header };
+    }, {});
   }
 
   private static parseHeader(header: string): [string, string] | undefined {