Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proxy): add --proxy-domains flag for domain-specific proxying with wildcard support #582

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

maksadbek
Copy link
Collaborator

@maksadbek maksadbek commented Aug 3, 2024

  • Rename “proxy-internal” to “proxy-target”.
  • Rename “proxy-external” to “proxy-bright”.
  • Add a new “proxy-domains” flag as an optional flag. It can be accepted when the user is setting either “proxy-target” or “proxy”. It can receive a comma-separated list of domains which will be proxied. Any domain that is not part of the list won’t be proxied. Notes: Support for wildcard is required. If I specify “*.foo.bar” as one of the domains, “a.foo.bar”, “b.foo.bar”, etc. will all be proxied.
  • Bright domains will always be proxied when using with the “proxy” flag, without a need to have them explicitly listed as part of the “proxy-domains” list. if the user doesn’t want to proxy bright domains, he should use only "proxy-target"

@maksadbek maksadbek self-assigned this Aug 3, 2024
@maksadbek maksadbek marked this pull request as draft August 3, 2024 14:18
@maksadbek maksadbek marked this pull request as ready for review August 3, 2024 21:23
Copy link
Collaborator

@denis-maiorov-brightsec denis-maiorov-brightsec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow conventional commits

src/Config/CliBuilder.ts Outdated Show resolved Hide resolved
src/Config/CliBuilder.ts Outdated Show resolved Hide resolved
src/Utils/Proxy/HttpProxyAgent.ts Outdated Show resolved Hide resolved
src/Utils/Wildcard.ts Outdated Show resolved Hide resolved
@maksadbek maksadbek changed the title bypass proxy with domain settings selective proxy with domain settings Aug 5, 2024
@maksadbek maksadbek force-pushed the bypass-proxy-with-domain-settings branch from 450eb4c to 9f90dde Compare August 5, 2024 21:03
@maksadbek maksadbek force-pushed the bypass-proxy-with-domain-settings branch from 47080e2 to efc4df6 Compare August 6, 2024 07:31
Copy link
Collaborator

@denis-maiorov-brightsec denis-maiorov-brightsec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust PR title to follow conventional commits. PR title is the header of commit and PR description act as body+footer

src/RequestExecutor/HttpRequestExecutor.ts Outdated Show resolved Hide resolved
maksadbek and others added 2 commits August 6, 2024 14:01
Co-authored-by: denis-maiorov-brightsec <103932492+denis-maiorov-brightsec@users.noreply.github.com>
@maksadbek maksadbek changed the title selective proxy with domain settings feat(proxy): add --proxy-domains flag for domain-specific proxying with wildcard support Aug 6, 2024
@maksadbek
Copy link
Collaborator Author

@denis-maiorov-brightsec done

@maksadbek maksadbek added the Type: enhancement New feature or request. label Aug 6, 2024
Copy link
Collaborator

@denis-maiorov-brightsec denis-maiorov-brightsec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@denis-maiorov-brightsec denis-maiorov-brightsec enabled auto-merge (squash) August 7, 2024 10:20
@denis-maiorov-brightsec denis-maiorov-brightsec merged commit 3dd3b65 into next Aug 7, 2024
6 checks passed
@denis-maiorov-brightsec denis-maiorov-brightsec deleted the bypass-proxy-with-domain-settings branch August 7, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants