Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add commands to control discoveries #621

Merged
merged 10 commits into from
Dec 3, 2024
Merged

feat: add commands to control discoveries #621

merged 10 commits into from
Dec 3, 2024

Conversation

SevenWhite
Copy link
Contributor

@SevenWhite SevenWhite commented Nov 28, 2024

Add commands to control discoveries:

  • discovery:run [options] to start a new discovery for the received configuration.
  • discovery:stop [options] <discoveryId> to stop a discovery by id.
  • discovery:rerun [options] <discoveryId> to request to start a new discovery using the same configuration as an existing discovery, by discovery ID.

@SevenWhite SevenWhite requested a review from maksadbek November 28, 2024 09:43
@SevenWhite SevenWhite self-assigned this Nov 28, 2024
@maksadbek maksadbek added Type: enhancement New feature or request. javascript Pull requests that update Javascript code labels Nov 28, 2024
src/Commands/RunDiscovery.ts Outdated Show resolved Hide resolved
src/Commands/RunDiscovery.ts Outdated Show resolved Hide resolved
src/Commands/RunDiscovery.ts Outdated Show resolved Hide resolved
src/Commands/StopDiscovery.ts Show resolved Hide resolved
@SevenWhite SevenWhite requested a review from orubin December 2, 2024 10:04
@maksadbek
Copy link
Collaborator

@SevenWhite could you add more information to the PR title and description please ? This will go as a single commit and we should have more descriptive messages there.

@SevenWhite SevenWhite changed the title feat: discoveries feat: add commands to control discoveries Dec 2, 2024
@SevenWhite
Copy link
Contributor Author

@SevenWhite could you add more information to the PR title and description please? This will go as a single commit and we should have more descriptive messages there.

Thanks for the suggestion!

@maksadbek maksadbek merged commit 8010670 into next Dec 3, 2024
6 checks passed
@maksadbek maksadbek deleted the feat/discoveries branch December 3, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code Type: enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants