Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read spike times in CedIO #1014

Merged
merged 3 commits into from
Jul 9, 2021

Conversation

samuelgarcia
Copy link
Contributor

@eduardacenteno : could you test this on your data ?

@pep8speaks
Copy link

pep8speaks commented Jul 7, 2021

Hello @samuelgarcia! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-07 17:47:22 UTC

@samuelgarcia samuelgarcia added this to the 0.10.0 milestone Jul 7, 2021
@eduardacenteno
Copy link

Hey @samuelgarcia @JuliaSprenger ! Just checked obtaining the spike times from a smrx files, and it works fine!

I compared a .smr file using Spike2IO and the same file in smrx using the CED. They match, and it’s what I see in spike2.

Let me know when you need any checks for the waveforms :)

Thanks again!

@bendichter, this relates to what we talked about a couple of months back in #424

@samuelgarcia
Copy link
Contributor Author

Hi Eduarda.
The waveforms are not extracted here.
I don't think I will have time to do it before release.
If it works for you i propose to merge.

@eduardacenteno
Copy link

Hey Sam, I know, I know. I meant if you implement it, if you need anyone to check it, let me know :)

@JuliaSprenger JuliaSprenger merged commit 400c042 into NeuralEnsemble:master Jul 9, 2021
@samuelgarcia samuelgarcia deleted the ced_read_spikes branch March 9, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants