Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.13 to CI #1582

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/workflows/core-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
matrix:
os: ["ubuntu-latest", "windows-latest"]
# "macos-latest",
python-version: ['3.9', '3.10', '3.11', '3.12']
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
numpy-version: ['1.22.4', '1.23.5', '1.24.1', '1.25.1', '1.26.4']
exclude:
- python-version: '3.12'
Expand All @@ -37,14 +37,22 @@ jobs:
numpy-version: '1.24.1'
- python-version: '3.12'
numpy-version: '1.25.1'
- python-version: '3.13'
numpy-version: '1.22.4'
- python-version: '3.13'
numpy-version: '1.23.5'
- python-version: '3.13'
numpy-version: '1.24.1'
- python-version: '3.13'
numpy-version: '1.25.1'
steps:
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}

- name: Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install numpy ${{ matrix.numpy-version }}
run: |
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/io-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@ jobs:
strategy:
fail-fast: true
matrix:
python-version: ['3.9', '3.11']
python-version: ['3.9', '3.13']
defaults:
# by default run in bash mode (required for conda usage)
run:
shell: bash -l {0}
steps:

- name: Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Get current year-month
id: date
Expand All @@ -38,7 +38,7 @@ jobs:
run: |
echo "dataset_hash=$(git ls-remote https://gin.g-node.org/NeuralEnsemble/ephy_testing_data.git HEAD | cut -f1)" >> $GITHUB_OUTPUT

- uses: actions/cache/restore@v3
- uses: actions/cache/restore@v4
# Loading cache of ephys_testing_dataset
id: cache-datasets
with:
Expand All @@ -56,7 +56,7 @@ jobs:
run: |
echo "hash=${{hashFiles('**/pyproject.toml', '**/environment_testing.yml')}}" >> $GITHUB_OUTPUT

- uses: actions/cache/restore@v3
- uses: actions/cache/restore@v4
# the cache for python package is reset:
# * every month
# * when package dependencies change
Expand Down
4 changes: 2 additions & 2 deletions neo/rawio/plexon2rawio/plexon2rawio.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class Plexon2RawIO(BaseRawIO):
pl2_dll_file_path: str | Path | None, default: None
The path to the necessary dll for loading pl2 files
If None will find correct dll for architecture and if it does not exist will download it
reading_attempts: int, default: 25
reading_attempts: int, default: 35
Number of attempts to read the file before raising an error
This opening process is somewhat unreliable and might fail occasionally. Adjust this higher
if you encounter problems in opening the file.
Expand Down Expand Up @@ -93,7 +93,7 @@ class Plexon2RawIO(BaseRawIO):
extensions = ["pl2"]
rawmode = "one-file"

def __init__(self, filename, pl2_dll_file_path=None, reading_attempts=25):
def __init__(self, filename, pl2_dll_file_path=None, reading_attempts=35):

# signals, event and spiking data will be cached
# cached signal data can be cleared using `clear_analogsignal_cache()()`
Expand Down
Loading