Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DnCManager Class #143

Merged
merged 37 commits into from
Jun 18, 2019
Merged

DnCManager Class #143

merged 37 commits into from
Jun 18, 2019

Conversation

wu-haoze
Copy link
Collaborator

  1. Create DnC Manager class that spawns multiple threads, each of which creates a DnCWorker object and runs it.
  2. Corresponding changes in Makefiles.
  3. Will add unit test in subsequent pull request.

wu-haoze and others added 21 commits June 1, 2019 01:23
guykatzz
guykatzz reviewed Jun 15, 2019
View reviewed changes
Rules.mk Outdated Show resolved Hide resolved
guykatzz
guykatzz reviewed Jun 16, 2019
View reviewed changes
src/engine/DnCManager.h Outdated Show resolved Hide resolved
src/engine/DnCManager.cpp Outdated Show resolved Hide resolved
@wu-haoze wu-haoze merged commit 8f49de9 into NeuralNetworkVerification:master Jun 18, 2019
matanost pushed a commit that referenced this pull request Nov 2, 2021
@wu-haoze
DnCManager Class (#143)
fa7658a 
* QueryDivider and LargestIntervalDivider

* fix style

* add boost to local include and library dir in makefiles

* some comments

* change vectors to Lists, consistent naming of SubQuery objects

* change subquery from tuple to struct

* fix an assertion

* minor editing

* add unique test for LargestIntervalDivider.h

* minor change

* style fix

* dncManager skeleton

* dnc related changes

* remove import

* cosmetics

* clean up

* small fix

* cosmetics

* cosmetics and a few comments

* addressing Guy's comments

* change options in Makefile

* pthread only used in linking, not compilation

* makefiles

* cleanup

* c'tors

* a few more comments and todos

* travis

* boost includes

* delete workload object in destructor in DnCManager

* add a comment

* clean up

* minor

* oops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guykatzz guykatzz guykatzz left review comments

@AleksandarZeljic AleksandarZeljic Awaiting requested review from AleksandarZeljic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wu-haoze @guykatzz @GuyKatzHuji