DnC Marabou #152
Merged
DnC Marabou #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
* QueryDivider and LargestIntervalDivider * fix style * add boost to local include and library dir in makefiles * some comments * change vectors to Lists, consistent naming of SubQuery objects * change subquery from tuple to struct * fix an assertion * minor editing * add unique test for LargestIntervalDivider.h * minor change * style fix * dncManager skeleton * dnc related changes * remove import * cosmetics * clean up * small fix * cosmetics * cosmetics and a few comments * addressing Guy's comments * change options in Makefile * pthread only used in linking, not compilation * makefiles * cleanup * c'tors * a few more comments and todos * travis * boost includes * delete workload object in destructor in DnCManager * add a comment * clean up * minor * oops * cosmetics * stored initial engine state only once * Update SmtCore.h * dnc marabou * add timeout functionality * clean up * move split first in DnCWorker * fix corner case in updateDnCExitCode * add verbosity * clean up * cosmetics * no timeout factor in query divider * option parsers, runner classes * minor * minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example usage:
./marabou.elf /path/to/network /path/to/property --dnc --verbosity=0 --timeout=600 --num-workers=8Runtime comparison between python DnC and C++ DnC using 8 workers, 20 minutes timeout:
https://docs.google.com/spreadsheets/d/1cMSX_tbc9UXojj3qwm9gwrUeJa4y3tYzKAU6p2I2_Is/edit?usp=sharing
Python implementation takes a little shorter time as expected (it uses more sophisticated splitting strategy), but the results appear to be sound.