Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump query #167

Merged
Merged

Conversation

yuvaljacoby
Copy link
Collaborator

No description provided.

@@ -103,7 +103,9 @@ void createInputQuery(InputQuery &inputQuery, std::string networkFilePath, std::
printf( "Property: None\n" );
}

std::pair<std::map<int, double>, Statistics> solve(InputQuery inputQuery, std::string redirect="", unsigned timeout=0){
/* The default parameters here are just for readability, you should specify
* them in the to make them work*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentence is broken

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is to keep it less then 80 characters.
We don't want that?

maraboupy/MarabouCore.cpp Outdated Show resolved Hide resolved
@yuvaljacoby
Copy link
Collaborator Author

Tried to create a test for maraboupy to make sure no memory leaks.
Had trouble with the compilation, I think I will try to simplify the compilation process (cmake) and then get back to write the test, anyway the python changes here are small but are suppose to save time for new users using the python

A bit more about the compilation difficulties I had -
I needed to extend the MockEngine & IEngine (to have solve method) .
Then tried to change the MarabouCore to work with IEngine and then stuff started to break in MarabouCore and in SmtCore tests

@yuvaljacoby
Copy link
Collaborator Author

@guykatzz Can I merge this?

@guykatzz
Copy link
Collaborator

guykatzz commented Oct 6, 2019

Yes

@yuvaljacoby yuvaljacoby merged commit 2a2bc0d into NeuralNetworkVerification:master Oct 8, 2019
@yuvaljacoby yuvaljacoby deleted the dump_query branch October 8, 2019 20:53
AleksandarZeljic pushed a commit to AleksandarZeljic/Marabou that referenced this pull request Oct 9, 2020
Add verbosity option to PY API
Fix MarabouCore default arguments
matanost pushed a commit that referenced this pull request Nov 2, 2021
Add verbosity option to PY API
Fix MarabouCore default arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants