add macro to only call sched_getcpu on linux #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure "common/CrossPlatform.h" is the place for this code - maybe just for the definition of a LINUX( ... ) macro. The rest of the code is very specific to DnC, so should be included within the DnC files. Or, alternatively, you can rename it to something more general (getCPUData, or something), and leave it under common. |
|
LGTM |
yuvaljacoby
pushed a commit
to yuvaljacoby/Marabou-1
that referenced
this pull request
Oct 7, 2019
…ation#177) * add macro to only call sched_getcpu on linux * cross platform get cpu id * cosmetics and rename filename * small fix
AleksandarZeljic
pushed a commit
to AleksandarZeljic/Marabou
that referenced
this pull request
Oct 9, 2020
…ation#177) * add macro to only call sched_getcpu on linux * cross platform get cpu id * cosmetics and rename filename * small fix
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
* add macro to only call sched_getcpu on linux * cross platform get cpu id * cosmetics and rename filename * small fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.