fix -Wmisleading-indentation warnings #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of GCC (e.g. 7.2.0) include -Wmisleading-indentation in -Wall, causing compilation to fail on a couple of files. Herein we fix the specific lines causing warnings.
|
Thanks for the note about C++11. Let's be careful that this isn't causing issues down the line. @guykatzz |
|
Debugged this a bit more and discovered the flags are being passed down correctly. I think GCC is referencing C++11 in its warnings because this is what C++0x became. I was not aware of this and had previously thought C++0x was a distinct, prior standard. |
yuvaljacoby
pushed a commit
to yuvaljacoby/Marabou-1
that referenced
this pull request
Jun 9, 2020
…ification/master Merge from master
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
Newer versions of GCC (e.g. 7.2.0) include -Wmisleading-indentation in -Wall, causing compilation to fail on a couple of files. Herein we fix the specific lines causing warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only fixed the indentation issues in this commit, not GCC 7.2.0's other complaint (throwing from destructors). The other warnings are in cxxtest code and it did not seem like the correct solution to modify the third-party code. Another interesting aspect is that my build output implies GCC is issuing these warnings because it is compiling as C++11. The top level makefiles set C++0x, so maybe somewhere down the recursive build the flags are being lost and GCC 7.2.0 is defaulting to C++11.