Onnx maraboupy parser #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clazarus
approved these changes
Jan 28, 2020
|
Thanks Chris! There's lots of valid ways to define on ONNX network, so I tried to make the equation functions robust, although that makes things more complicated. I think in the future there needs to be some sort of testing framework for the input parsers to make sure we're robust to many network types, and to make sure that a bug fix to accommodate new networks does not break functionality for other networks. But hopefully this is a good starting point for the ONNX parser. |
|
Hi Kyle, |
AleksandarZeljic
pushed a commit
to AleksandarZeljic/Marabou
that referenced
this pull request
Oct 9, 2020
* Adding ONNX parser for Marabou * Convolutional equations and examples * Add support for Reshape and Cast with new example * Add onnx version of example network
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
* Adding ONNX parser for Marabou * Convolutional equations and examples * Add support for Reshape and Cast with new example * Add onnx version of example network
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces an ONNX parser for Marabou. The format is very similar to parsing tensorflow models, though a few things are different. ONNX does not have functions for easily computing the output shape of intermediate layers, so the shapes of layers in the graph must be inferred from input shapes, constant shapes, and operations.
I tested the parser on ONNX models converted from tensorflow as well as the ACAS Xu prototype networks in ONNX format found in the VNNLIB repository. A new python script in examples shows how to load and solve queries for ONNX format networks that have been added to examples/networks.
I also fixed a minor bug in Marabou.read_tf to change inputName to inputNames to reflect the multi-input changes made in MarabouNetworkTF.