Add support for different branching heuristics #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guykatzz
reviewed
Feb 26, 2020
guykatzz
reviewed
Feb 26, 2020
guykatzz
reviewed
Feb 26, 2020
|
@anwu1219 there are conflict with the current master |
Fixed now. |
|
LGTM |
AleksandarZeljic
pushed a commit
to AleksandarZeljic/Marabou
that referenced
this pull request
Oct 9, 2020
…tion#221) * polarity based direction heuristic * Update ReluConstraint.cpp * add more documentation and mino fixes for polarity-based direction heuristic * add relu divider * Update PiecewiseLinearConstraint.h * add unit tests * some changes * remove ReluDivider for now * add branching heuristic * sanity check * refactoring for modular branching decision * relusplit-pr * aesthetics * clean up * changes in style, terminology, removed _score definition in children classes * add setScore method and invoke in acasParser * rename branching to splitting * minor * rename branching to splitting * remove extra line
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
* polarity based direction heuristic * Update ReluConstraint.cpp * add more documentation and mino fixes for polarity-based direction heuristic * add relu divider * Update PiecewiseLinearConstraint.h * add unit tests * some changes * remove ReluDivider for now * add branching heuristic * sanity check * refactoring for modular branching decision * relusplit-pr * aesthetics * clean up * changes in style, terminology, removed _score definition in children classes * add setScore method and invoke in acasParser * rename branching to splitting * minor * rename branching to splitting * remove extra line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is needed both for DnC Relu Splitting (the CAV submission) and for experimenting with different branching heuristics within the SmtCore.
Future PR will include the polarity based branching heuristic, and relusplitting in the DnC module.