Fix clang, gcc >=7.3.0 issues. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clazarus
requested review from
ShantanuThakoor
and removed request for
clazarus
guykatzz
reviewed
Apr 29, 2018
Rules.mk
Outdated
| -Wno-deprecated \ | ||
| -std=c++0x \ | ||
| \ | ||
| -g \ | ||
|
|
||
| ifeq "$(GCCVERSION)" "7.3.0" |
There was a problem hiding this comment.
I think this affects other versions as well. For example, I have 6.3.0 and this warning already exists. Can you figure out when this warning was introduced, and check if the version is gte that version?
guykatzz
reviewed
Apr 29, 2018
src/engine/tests/Test_Tableau.h
Outdated
| @@ -1064,7 +1064,7 @@ class TableauTestSuite : public CxxTest::TestSuite | |||
|
|
|||
| // Do some more stuff | |||
| TS_ASSERT_THROWS_NOTHING( tableau->computeCostFunction() ); | |||
| tableau->setEnteringVariableIndex( 2u ); | |||
| tableau->setEnteringVariableIndex( tableau->variableToIndex( 2u ) ); | |||
There was a problem hiding this comment.
Does the test fail on mac without this change?
There was a problem hiding this comment.
No, actually the critical thing was the computeChangeColumn. I reverted these changes in the latest commit.
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
* fix: not changing dimensions for cost fn manager on restore. * Fix for compilation on very new gcc (7.3.0) * Fix uninitialized value issues in Test_Tableau: test_store_and_restore * Fix so that gcc <7.3.0 and clang can still compile * Fix a typo and revert the additional assertions introduced. * Fix additional bug in Test_Tableau. * this only needs to affect cxx compilation * oops * disable terminate flag if g++ >=6.1 * oops * Fix macOS Make issues. Revert one line in Test_Tableau * revert other variableToIndex call in Test_Tableau * warning about supported platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for guykatzz#21