Onnx gemm attributes #242
Merged
Onnx gemm attributes #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fication/master Merge from master
AleksandarZeljic
pushed a commit
to AleksandarZeljic/Marabou
that referenced
this pull request
Oct 9, 2020
* Handle more cases for Gemm and Matmul * Remove extra space Co-authored-by: Kyle Julian <kjulian3.stanford.edu>
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
* Handle more cases for Gemm and Matmul * Remove extra space Co-authored-by: Kyle Julian <kjulian3.stanford.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #239 by adding support for the four Gemm attributes (transA, transB, alpha, and beta), as well as fixing an edge case for the Matmul function. These bugs were found using networks exported from PyTorch.