Preprocess the input query only once in DnC #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmed-irfan
reviewed
Apr 22, 2020
ahmed-irfan
reviewed
Apr 24, 2020
AleksandarZeljic
pushed a commit
to AleksandarZeljic/Marabou
that referenced
this pull request
Oct 9, 2020
…n#248) Currently in DnC, inputQuery is preprocessed multiple times. This PR preprocess the inputQuery once with the baseEngine in DnCManager, and the worker engines only copy over the preprocessed input query. * preprocess input query only once in DnC * remove external headers * fix memory leak * use wrap input query in dnc manager with unique ptr
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
Currently in DnC, inputQuery is preprocessed multiple times. This PR preprocess the inputQuery once with the baseEngine in DnCManager, and the worker engines only copy over the preprocessed input query. * preprocess input query only once in DnC * remove external headers * fix memory leak * use wrap input query in dnc manager with unique ptr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in DnC, inputQuery is preprocessed multiple times.
This PR preprocess the inputQuery once with the baseEngine in DnCManager, and the worker engines only copy over the preprocessed input query.