Maraboupy imports parsers only when required packages are installed #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fication/master Merge from master
kjulian3
requested review from
clazarus and
wu-haoze
and removed request for
clazarus
wu-haoze
approved these changes
May 7, 2020
AleksandarZeljic
pushed a commit
to AleksandarZeljic/Marabou
that referenced
this pull request
Oct 9, 2020
…euralNetworkVerification#257) * Try importing parsers * Give warnings Co-authored-by: Guy Katz <guyk@cs.stanford.edu> Co-authored-by: Kyle Julian <kjulian3.stanford.edu>
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
…257) * Try importing parsers * Give warnings Co-authored-by: Guy Katz <guyk@cs.stanford.edu> Co-authored-by: Kyle Julian <kjulian3.stanford.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr addresses #256. By catching ImportErrors when importing the tensorflow and onnx parsers, we can prevent errors caused by tensorflow or onnx/onnxruntime not being installed. This allows tensorflow users to use maraboupy without ever needing to install or worry about onnx/onnxruntime. They'd be able to use Marabou.read_tf(), but would get an error if they tried to run Marabou.read_onnx().
Users do get a warning when they import Marabou but don't have tensorflow or onnx/onnxruntime installed. The warning will let people that they need to install some packages if they want to use that input parser. However, they will still be able to use Maraboupy's other parsers without error.