Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New onnx tests and bug fix caught with new tests #261

Merged
merged 12 commits into from
May 18, 2020
Merged

New onnx tests and bug fix caught with new tests #261

merged 12 commits into from
May 18, 2020

Conversation

kjulian3
Copy link
Collaborator

@kjulian3 kjulian3 commented May 7, 2020

This pr does a few things:

  • Reformats onnx tests to make adding new tests easier
  • Uses 20 random test points for each network to make tests more reliable
  • Adds three new tests to cover different types of neural network layers
  • Adds support for a Constant layer, needed by conv_mp1.onnx
  • Fixes bug when generating Conv equations. Networks exported from tensorflow did not use the optional third input for the filter biases, so bug went undetected. The conv_mp1.onnx model, exported from pytorch, uses the optional input, so testing with that network caught the bug.

guykatzz and others added 11 commits April 1, 2020 16:24
@guykatzz
Merge pull request NeuralNetworkVerification#2 from NeuralNetworkVeri…
0294146 
…fication/master

Merge from master
@kjulian3
Merge pull request #1 from NeuralNetworkVerification/master
2124a69 
Update fork
@guykatzz
Merge pull request NeuralNetworkVerification#4 from NeuralNetworkVeri…
49d06bf 
…fication/master

Merge from master
@guykatzz
Merge pull request NeuralNetworkVerification#5 from NeuralNetworkVeri…
fe44808 
…fication/master

Merge from master
@guykatzz
Merge pull request NeuralNetworkVerification#8 from NeuralNetworkVeri…
f08849c 
…fication/master

Merge from master
@guykatzz
Merge pull request NeuralNetworkVerification#11 from NeuralNetworkVer…
ed4244c 
…ification/master

Symbolic bound tightening in NLR (NeuralNetworkVerification#249)
@guykatzz
Merge pull request NeuralNetworkVerification#14 from NeuralNetworkVer…
d9ec094 
…ification/master

Symbolic bound tightening over absolute values (NeuralNetworkVerification#251)
Merge remote-tracking branch 'upstream/master'
7c2e2c5
Merge remote-tracking branch 'upstream/master'
d3e8839
Add new tests and bug fix
0b14f71
Add onnx networks
03ea9b8
@kjulian3 kjulian3 requested a review from wu-haoze May 7, 2020 23:33
wu-haoze
wu-haoze approved these changes May 18, 2020
View reviewed changes
Copy link
Collaborator

@wu-haoze wu-haoze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work on my machine. LGTM

@kjulian3 kjulian3 merged commit b775aa3 into NeuralNetworkVerification:master May 18, 2020
@kjulian3 kjulian3 deleted the onnx_tests branch May 18, 2020 05:06
AleksandarZeljic pushed a commit to AleksandarZeljic/Marabou that referenced this pull request Oct 9, 2020
@kjulian3 @AleksandarZeljic
New onnx tests and bug fix caught with new tests (NeuralNetworkVerifi…
0d2699d 
…cation#261)

* Add new tests and bug fix

* Add onnx networks

* rename TinyTaxiNet

Co-authored-by: Kyle Julian <kjulian3.stanford.edu>
matanost pushed a commit that referenced this pull request Nov 2, 2021
@kjulian3
New onnx tests and bug fix caught with new tests (#261)
c767640 
* Add new tests and bug fix

* Add onnx networks

* rename TinyTaxiNet

Co-authored-by: Kyle Julian <kjulian3.stanford.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-haoze wu-haoze wu-haoze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjulian3 @wu-haoze @guykatzz