-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup codecov for maraboupy #265
Setup codecov for maraboupy #265
Conversation
…fication/master Merge from master
…fication/master Merge from master
…fication/master Merge from master
…fication/master Merge from master
…ification/master Symbolic bound tightening in NLR (NeuralNetworkVerification#249)
…ification/master Symbolic bound tightening over absolute values (NeuralNetworkVerification#251)
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
=========================================
Coverage ? 34.68%
=========================================
Files ? 13
Lines ? 1730
Branches ? 0
=========================================
Hits ? 600
Misses ? 1130
Partials ? 0 Continue to review full report at Codecov.
|
The codecov report can be found here: https://codecov.io/gh/NeuralNetworkVerification/Marabou Seems like the default behavior is to comment on each pull request with how the code coverage changes with the pull request. Right now the master doesn't have a codecov report, so the comparison isn't helpful. Do we want to keep these reports automatically commenting on each pull request? That seems annoying an unnecessary to me. We'll have to make more changes to setup C++ code coverage, but I think we can save that for the next pull request, unless it's easy to add. |
I think we should add a badge to the README file (similar to CVC4 ) which I hope will encourage us to add more tests :) I will take a look on maraboupy/tests.py later and add it to the "suite" |
I switched to codecov.yml instead of .coveragerc, which gives us the option to disable pr comments as well as access to more options that may be helpful for integrating c++ code coverage in the future. |
* Setup codecov for maraboupy * Remove extra lines * Setup codecov.yml, disable pr comments Co-authored-by: Kyle Julian <kjulian3.stanford.edu>
* Setup codecov for maraboupy * Remove extra lines * Setup codecov.yml, disable pr comments Co-authored-by: Kyle Julian <kjulian3.stanford.edu>
This sets up codecov for the maraboupy python files. The new file pytest.ini configures pytest calls to include code coverage of the maraboupy folder. The new file .coveragerc controls the options for the python code coverage, such as which files should be omitted. Other options can be added in the future if needed.