Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup codecov for maraboupy #265

Merged
merged 14 commits into from
May 19, 2020

Conversation

kjulian3
Copy link
Collaborator

This sets up codecov for the maraboupy python files. The new file pytest.ini configures pytest calls to include code coverage of the maraboupy folder. The new file .coveragerc controls the options for the python code coverage, such as which files should be omitted. Other options can be added in the future if needed.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@90b3be0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #265   +/-   ##
=========================================
  Coverage          ?   34.68%           
=========================================
  Files             ?       13           
  Lines             ?     1730           
  Branches          ?        0           
=========================================
  Hits              ?      600           
  Misses            ?     1130           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90b3be0...565caae. Read the comment docs.

@kjulian3
Copy link
Collaborator Author

The codecov report can be found here: https://codecov.io/gh/NeuralNetworkVerification/Marabou

Seems like the default behavior is to comment on each pull request with how the code coverage changes with the pull request. Right now the master doesn't have a codecov report, so the comparison isn't helpful. Do we want to keep these reports automatically commenting on each pull request? That seems annoying an unnecessary to me.

We'll have to make more changes to setup C++ code coverage, but I think we can save that for the next pull request, unless it's easy to add.

@kjulian3 kjulian3 requested a review from yuvaljacoby May 19, 2020 07:23
@yuvaljacoby
Copy link
Collaborator

yuvaljacoby commented May 19, 2020

  • I don't think we need to push a report on every pull request
  • I agree that we can deal with c++ later

I think we should add a badge to the README file (similar to CVC4 ) which I hope will encourage us to add more tests :)

I will take a look on maraboupy/tests.py later and add it to the "suite"
@anwu1219 do we have any DNC tests ?

@kjulian3
Copy link
Collaborator Author

I switched to codecov.yml instead of .coveragerc, which gives us the option to disable pr comments as well as access to more options that may be helpful for integrating c++ code coverage in the future.

@kjulian3 kjulian3 merged commit 60d989f into NeuralNetworkVerification:master May 19, 2020
@kjulian3 kjulian3 deleted the python-codecov branch May 19, 2020 22:07
AleksandarZeljic pushed a commit to AleksandarZeljic/Marabou that referenced this pull request Oct 9, 2020
* Setup codecov for maraboupy

* Remove extra lines

* Setup codecov.yml, disable pr comments

Co-authored-by: Kyle Julian <kjulian3.stanford.edu>
matanost pushed a commit that referenced this pull request Nov 2, 2021
* Setup codecov for maraboupy

* Remove extra lines

* Setup codecov.yml, disable pr comments

Co-authored-by: Kyle Julian <kjulian3.stanford.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants