Polarity-based Splitting Heuristics #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add mapping from Index to PlConstraint in NetworkLevelReasoner
|
is it ready for review? it is tagged with |
Not yet. Still need to fix something. Will ping when it's ready. |
ahmed-irfan
reviewed
Jun 1, 2020
ahmed-irfan
reviewed
Jun 1, 2020
ahmed-irfan
requested changes
Jun 1, 2020
ahmed-irfan
reviewed
Jun 2, 2020
ahmed-irfan
reviewed
Jun 2, 2020
AleksandarZeljic
pushed a commit
to AleksandarZeljic/Marabou
that referenced
this pull request
Oct 9, 2020
* add run time estimate threhsold * Add Polarity to DivideStrategy Add mapping from Index to PlConstraint in NetworkLevelReasoner * implementing polarity based heuristics (WIP) * set default to polarity * Polarity * fix bug * fix another bug * change back to default * add some documentation * remove set splitting strategy * clean up * clean up * turn off logging * set default back to relu violation * clean up * cosmetic * add comment in smtcore * remove return statements
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
* add run time estimate threhsold * Add Polarity to DivideStrategy Add mapping from Index to PlConstraint in NetworkLevelReasoner * implementing polarity based heuristics (WIP) * set default to polarity * Polarity * fix bug * fix another bug * change back to default * add some documentation * remove set splitting strategy * clean up * clean up * turn off logging * set default back to relu violation * clean up * cosmetic * add comment in smtcore * remove return statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add polarity-based splitting heuristics as one of the internal splitting strategy.
On 180 ACAS benchmarks with 20 min timeout, new strategy solved 116 instance in 13390 secs. Original splitting strategy solved 116 instances in 17142 secs.
Still need to add/fix some tests.