-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for Marabou.py and MarabouUtils.py #278
Merged
kjulian3
merged 17 commits into
NeuralNetworkVerification:master
from
kjulian3:pytest_utils
Jun 10, 2020
Merged
Tests for Marabou.py and MarabouUtils.py #278
kjulian3
merged 17 commits into
NeuralNetworkVerification:master
from
kjulian3:pytest_utils
Jun 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fication/master Merge from master
…fication/master Merge from master
…fication/master Merge from master
…fication/master Merge from master
…ification/master Symbolic bound tightening in NLR (NeuralNetworkVerification#249)
…ification/master Symbolic bound tightening over absolute values (NeuralNetworkVerification#251)
wu-haoze
reviewed
Jun 10, 2020
wu-haoze
reviewed
Jun 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small cosmetic comment. Otherwise, LGTM
AleksandarZeljic
pushed a commit
to AleksandarZeljic/Marabou
that referenced
this pull request
Oct 9, 2020
* Add more tests for Marabou.py and MarabouUtils.py * Tolerance for equality constraints * Test verbose * new lines Co-authored-by: Kyle Julian <kjulian3@stanford.edu>
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
* Add more tests for Marabou.py and MarabouUtils.py * Tolerance for equality constraints * Test verbose * new lines Co-authored-by: Kyle Julian <kjulian3@stanford.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds more tests for function in Marabou.py and MarabouUtils.py that have not been previously tested. These tests check that equality and inequality constraints can be applied to the query and are solved correctly. In addition, a test checks that a query exported to a text file can be re-read and evaluated to produce the same results as the original query. Minor changes for clarity are added to the tensorflow tests as well.