Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for Marabou.py and MarabouUtils.py #278

Merged
merged 17 commits into from
Jun 10, 2020

Conversation

kjulian3
Copy link
Collaborator

@kjulian3 kjulian3 commented Jun 5, 2020

This pull request adds more tests for function in Marabou.py and MarabouUtils.py that have not been previously tested. These tests check that equality and inequality constraints can be applied to the query and are solved correctly. In addition, a test checks that a query exported to a text file can be re-read and evaluated to produce the same results as the original query. Minor changes for clarity are added to the tensorflow tests as well.

@kjulian3 kjulian3 requested a review from wu-haoze June 5, 2020 04:28
Copy link
Collaborator

@wu-haoze wu-haoze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small cosmetic comment. Otherwise, LGTM

@kjulian3 kjulian3 merged commit 198c39c into NeuralNetworkVerification:master Jun 10, 2020
@kjulian3 kjulian3 deleted the pytest_utils branch June 10, 2020 20:49
AleksandarZeljic pushed a commit to AleksandarZeljic/Marabou that referenced this pull request Oct 9, 2020
* Add more tests for Marabou.py and MarabouUtils.py

* Tolerance for equality constraints

* Test verbose

* new lines

Co-authored-by: Kyle Julian <kjulian3@stanford.edu>
matanost pushed a commit that referenced this pull request Nov 2, 2021
* Add more tests for Marabou.py and MarabouUtils.py

* Tolerance for equality constraints

* Test verbose

* new lines

Co-authored-by: Kyle Julian <kjulian3@stanford.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants