Tests and fixes for maraboupy's NNet input parser #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fication/master Merge from master
…fication/master Merge from master
…fication/master Merge from master
…fication/master Merge from master
…ification/master Symbolic bound tightening in NLR (NeuralNetworkVerification#249)
…ification/master Symbolic bound tightening over absolute values (NeuralNetworkVerification#251)
guykatzz
approved these changes
Jun 9, 2020
AleksandarZeljic
pushed a commit
to AleksandarZeljic/Marabou
that referenced
this pull request
Oct 9, 2020
…ication#280) * Tests for NNet * Simplify normalization function * Marabou.py * Add new line Co-authored-by: Kyle Julian <kjulian3@stanford.edu>
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
* Tests for NNet * Simplify normalization function * Marabou.py * Add new line Co-authored-by: Kyle Julian <kjulian3@stanford.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr addresses #279 and adds tests for maraboupy's NNet input parser. A boolean option was added to Marabou.read_nnet() to allow users to define properties in the original input and output spaces by adjusting the parameters of the first and last layer to incorporate the normalization. As a result, users can define properties more intuitively without worrying about normalization. The tests added demonstrate this new functionality as well as existing functionality.
This may clash with some changes in #277, but it should be minimal.