Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the statistics object even if verbosity is 0 #284

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

wu-haoze
Copy link
Collaborator

When verbosity is set to 0, _statistics in Engine.h is not updated. However, the precision restoration depends on _statistics. Therefore, we update the _statistics even if we do not print it out.

@wu-haoze wu-haoze requested a review from kjulian3 June 11, 2020 20:29
@wu-haoze wu-haoze changed the title update mainloopstatistics even if verbosity is 0 update the statistics object even if verbosity is 0 Jun 11, 2020
@kjulian3
Copy link
Collaborator

This fixes the issue I was seeing where changing the verbosity results in different SAT points found.

@wu-haoze wu-haoze merged commit d273106 into NeuralNetworkVerification:master Jun 11, 2020
@wu-haoze wu-haoze deleted the fix-verbosity branch June 11, 2020 21:31
AleksandarZeljic pushed a commit to AleksandarZeljic/Marabou that referenced this pull request Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants