Cleaning examples folder #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, I'm confused why debug.ipynb is in the examples folder. @GuyKatzHuji, do you know why that file is present? |
wu-haoze
approved these changes
Jun 16, 2020
AleksandarZeljic
pushed a commit
to AleksandarZeljic/Marabou
that referenced
this pull request
Oct 9, 2020
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr updates the examples folder and removes outdated files.
In addition, this pr makes the ONNX and tensorflow parsers consistent in that the output variables preserves the batch_size dimension. Often, ONNX/tensorflow networks have an extra first dimension that represents the batch size, or number of input points to be evaluated. The tensorflow parser removes that extra dimension, but that causes the output shape to differ from ONNX. I think it's safest to just keep the extra dimension and let users handle it as needed.