Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep log lines only in debug mode #290

Merged
merged 6 commits into from
Jun 17, 2020

Conversation

yuvaljacoby
Copy link
Collaborator

Change all log functions into define's
Remove log define's in Release mode (deletes the whole line)

@yuvaljacoby yuvaljacoby requested a review from guykatzz June 16, 2020 13:14
Copy link
Collaborator

@guykatzz guykatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny cosmetic comments; otherwise, looks good. Thanks for taking care of this!

src/common/Debug.h Outdated Show resolved Hide resolved
src/common/Debug.h Outdated Show resolved Hide resolved
src/engine/ProjectedSteepestEdge.cpp Outdated Show resolved Hide resolved
@yuvaljacoby yuvaljacoby merged commit 594dce9 into NeuralNetworkVerification:master Jun 17, 2020
@yuvaljacoby yuvaljacoby deleted the log_debug branch June 17, 2020 14:40
AleksandarZeljic pushed a commit to AleksandarZeljic/Marabou that referenced this pull request Oct 9, 2020
Use pre-processor to get rid of log lines in Release mode
matanost pushed a commit that referenced this pull request Nov 2, 2021
Use pre-processor to get rid of log lines in Release mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants