move input query construction from preprocessor to inputquery #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guykatzz
reviewed
Jun 18, 2020
|
LGTM |
guykatzz
reviewed
Jun 30, 2020
| @@ -138,7 +138,7 @@ void PropertyParser::processSingleLine( const String &line, InputQuery &inputQue | |||
|
|
|||
| auto subToken = subTokens.begin(); | |||
| ++subToken; | |||
| unsigned layerIndex = atoi( subToken->ascii() ); | |||
| unsigned layerIndex = 2 * atoi( subToken->ascii() ) - 1; | |||
There was a problem hiding this comment.
Hmm...
So, it seems like this change is tightly coupled to the ACAS Xu architecture, of input, <fc,relu>*, output layers. Our NLR now supports general feed-forward topologies. I understand the motivation was to maintain the old ws indexing, but I'm not sure it's good to hard-code this.
AleksandarZeljic
pushed a commit
to AleksandarZeljic/Marabou
that referenced
this pull request
Oct 9, 2020
…NetworkVerification#296) * move input query construction from preprocessor to inputquery * reconstruct nlr * delete nlr before constructing it * apply the same change to DnCMaraou * add back preprocessor logging * fix bug in property parser
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
* move input query construction from preprocessor to inputquery * reconstruct nlr * delete nlr before constructing it * apply the same change to DnCMaraou * add back preprocessor logging * fix bug in property parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to call constructNLR() after loading the .nnet file, so that we can load bounds of internal variables in the property file.