Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove maraboupy README, simplify python part in main README #311

Merged
merged 2 commits into from
Jun 29, 2020
Merged

remove maraboupy README, simplify python part in main README #311

merged 2 commits into from
Jun 29, 2020

Conversation

yuvaljacoby
Copy link
Collaborator

@yuvaljacoby yuvaljacoby commented Jun 28, 2020 •
edited
Loading

fix #307

@yuvaljacoby yuvaljacoby requested a review from kjulian3 June 28, 2020 16:07
@yuvaljacoby yuvaljacoby mentioned this pull request Jun 28, 2020
Closed
@kjulian3
Copy link
Collaborator

Is build_python_x86.sh still up to date, or should this be removed? There's no mention of it in the readme.

@yuvaljacoby
Copy link
Collaborator Author

yuvaljacoby commented Jun 29, 2020 •
edited
Loading

Is build_python_x86.sh still up to date, or should this be removed? There's no mention of it in the readme.

good point!
It's an example (maybe not a very good one) for installing a python32 bit interface.
When the build process finds only a 32bit python, it prints a warning which points to this script.
added a reference from the README

kjulian3
kjulian3 approved these changes Jun 29, 2020
View reviewed changes
Copy link
Collaborator

@kjulian3 kjulian3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks good to me

@yuvaljacoby yuvaljacoby merged commit 0e5960c into NeuralNetworkVerification:master Jun 29, 2020
AleksandarZeljic pushed a commit to AleksandarZeljic/Marabou that referenced this pull request Oct 9, 2020
@yuvaljacoby @AleksandarZeljic
remove maraboupy README, simplify python part in main README (NeuralN…
4037231 
…etworkVerification#311)

* remove maraboupy README, simplify python part in main README

* add troubleshoot for python32 bit
matanost pushed a commit that referenced this pull request Nov 2, 2021
@yuvaljacoby
remove maraboupy README, simplify python part in main README (#311)
704ad08 
* remove maraboupy README, simplify python part in main README

* add troubleshoot for python32 bit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjulian3 kjulian3 kjulian3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The maraboupy directory does not have a Makefile
2 participants
@yuvaljacoby @kjulian3