Apply bounds after performing row bound tightening #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change LGTM. Lets see what the performance gain is. |
|
Hi Andrew, |
Hi Guy, on the commonly solved instances, there seem to be 10% runtime improvement. However, occasionally Marabou throws Error with the new changes, so I'm looking into that. |
…/Marabou into apply-bounds-after-tightening
|
On 40 acas, 40 mnist, 60 taxinet benchmarks, the two runs solve the same number of queries within 1 hour. |
guykatzz
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in solve() after we perform explicitBasisBoundTightening() we do not apply the updated bounds to _tableau until we have called **_tableau->allBoundsValid()"" and performSymbolicBoundTightening(). This could result in non-trivial delay in concluding UNSAT. This PR fixes this issue.
Runtime comparison pending...